Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: align PDNS provider by removing MatchParent #3869

Merged
merged 3 commits into from
Aug 23, 2023
Merged

fix!: align PDNS provider by removing MatchParent #3869

merged 3 commits into from
Aug 23, 2023

Conversation

matusf
Copy link
Contributor

@matusf matusf commented Aug 14, 2023

Description

PNDS provider is the only one which uses MatchParent functionality. The
MatchParent functionality breaks domain and regex domain filters. It
also makes PDNS provider behave differently than other providers while
having the same configuration. MatchParent can be replaced by using
multiple domain filters. After discussion with maintainers we concluded
that MatchParent should be removed.

The removal was discussed in #3828

Fixes #3816 #3828 #3822

Checklist

  • Unit tests updated
  • End user documentation updated

matusf added 3 commits August 14, 2023 11:14
@matusf
Add test for regex domain filter
8062095 
This test is expected to fail and aims to show that regex domain filter
is not working.
@matusf
Add docs for regex domain filter
2e00d42
@matusf
Align PDNS provider with other providers by removing MatchParent
7aa9d25 
PNDS provider is the only one which uses MatchParent functionality. The
MatchParent functionality breaks domain and regex domain filters. It
also makes PDNS provider behave differently than other providers while
having the same configuration. MatchParent can be replaced by using
multiple domain filters. After discussion with maintainers we concluded
that MatchParent should be removed.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @matusf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2023
@matusf matusf mentioned this pull request Aug 14, 2023
Closed
2 tasks
@k8s-ci-robot k8s-ci-robot changed the title Align PDNS provider with other providers by removing MatchParent fix: align PDNS provider by removing MatchParent Aug 14, 2023
@mloiseleur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2023
@k8s-ci-robot k8s-ci-robot changed the title fix: align PDNS provider by removing MatchParent BREAKING CHANGE: align PDNS provider by removing MatchParent Aug 14, 2023
@mloiseleur
Copy link
Contributor

/retitle fix!: align PDNS provider by removing MatchParent

@k8s-ci-robot k8s-ci-robot changed the title BREAKING CHANGE: align PDNS provider by removing MatchParent fix!: align PDNS provider by removing MatchParent Aug 14, 2023
@matusf
Copy link
Contributor Author

matusf commented Aug 14, 2023

/retest

@mloiseleur
Copy link
Contributor

/lgtm
/assign szuecs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2023
@szuecs
Copy link
Contributor

szuecs commented Aug 23, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matusf, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 24b4038 into kubernetes-sigs:master Aug 23, 2023
@mhanc mhanc mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@szuecs szuecs

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PowerDNS regex domain filter stopped working
4 participants
@matusf @k8s-ci-robot @mloiseleur @szuecs